Components: Refactor Guide tests to @testing-library/react
#43380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
tyxla
added
[Type] Bug
|
Size Change: +5 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Aug 19, 2022
There was a problem hiding this comment.
Love seeing this sort of refactors, the tests have gained a lot more value!
This also uncovers a bug: when we render with no pages, we attempt to focus the guide container, however it doesn't exist because we don't render it if no pages exist. This PR fixes that bug by changing the component to focus only if the guide container exists.
Amazing!
| * | ||
| * because the event sent has a `keyCode` of `0`. | ||
| * | ||
| * To fix this, we'll need to update the Modal component to work with `KeyboardEvent.code`. |
tyxla
force-pushed
the
refactor/guide-tests-rtl
branch
from
eb8d9fc to
f433923
Compare
Thanks a bunch, @ciampo! I've rebased after it landed and updated the tests to use This is now ready for another look. |
Co-authored-by: Marco Ciampini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We've recently started refactoring
enzymetests to@testing-library/react.This PR refactors the
<Guide />component tests fromenzymeto@testing-library/react.Why?
@testing-library/reactprovides a better way to write tests for accessible components that is closer to the way the user experiences them.How?
We're straightforwardly replacing
enzymetests with@testing-library/reactones, usingjest-dommatchers screen queries.This also uncovers a bug: when we render
<Guide />with no pages, we attempt to focus the guide container, however it doesn't exist because we don't render it if no pages exist. This PR fixes that bug by changing the component to focus only if the guide container exists.Testing Instructions
npm run test:unit packages/components/src/guide